alibaba-rsocket-broker icon indicating copy to clipboard operation
alibaba-rsocket-broker copied to clipboard

Published 20 hours ago • verified publisher icon alibaba

Modify code with refactors

Open francestang1117 opened this issue 2 years ago • 4 comments

Hi, I refactored some code. Hope you could check it. Thank you.

francestang1117 avatar Apr 07 '23 02:04 francestang1117

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Apr 07 '23 02:04 CLAassistant

@francestang1117 是不是 RSocketEncodingFacade.getInstance();更好一些？

 - protected RSocketEncodingFacade encodingFacade = RSocketEncodingFacade.getInstance();
 + protected RSocketEncodingFacade encodingFacade = RSocketEncodingFacade.getInstance(new RSocketEncodingFacadeImpl());

linux-china avatar Apr 24 '23 03:04 linux-china

Hi @linux-china, 这里我修改主要是觉得有一个Cyclically-dependent Modularization的smell.

francestang1117 avatar Apr 27 '23 20:04 francestang1117

Hi @linux-china, 这里我修改主要是觉得有一个Cyclically-dependent Modularization的smell.

好的，我看一下这个问题，看能否更好地修复一下。

linux-china avatar Apr 28 '23 01:04 linux-china