ai-matrix icon indicating copy to clipboard operation
ai-matrix copied to clipboard

Published 20 hours ago • verified publisher icon alibaba

DIEN implementation is not aligned with DIEN paper for some reason

Open andrei-kochin opened this issue 2 years ago • 2 comments

Hello,

Could you please kindly clarify the reason in 'u_t' calculation in DIEN model? https://github.com/alibaba/ai-matrix/blob/f7e1d7788c03e01eea915ff2bcad10103dcb529e/macro_benchmark/DIEN/script/utils.py#L217

According to DIEN paper it should be u_t =a_t*u_t and in your implementation it is u_t = (1.0 - a_t) * u_t

Looking forward for your reply.

Thank you!

andrei-kochin avatar Jul 19 '22 07:07 andrei-kochin

Paper: https://arxiv.org/pdf/1809.03672.pdf

Formulas 11-12: image

jane-intel avatar Jul 19 '22 08:07 jane-intel

@rabbitwayne, @xulingjie @madeye @parallelo @ could you please help us to comment on that?

andrei-kochin avatar Jul 19 '22 10:07 andrei-kochin