Sentinel icon indicating copy to clipboard operation
Sentinel copied to clipboard

[BUG] 指标文件读取方法不正确

Open brucelwl opened this issue 1 year ago • 3 comments

https://github.com/alibaba/Sentinel/blob/195150bc745927429e9f14f501907310b46d702f/sentinel-core/src/main/java/com/alibaba/csp/sentinel/node/metric/MetricSearcher.java#L208-L211

209行 offset = indexIn.readLong(); 不应该写, 应该剔除这行, 这样会导致读取的数据不正确

假如读取的是 1729965161000L的数据, 返回的是1729965162000L及之后的数据, 但如果1729965161000L是文件的最后一个时间的记录数据, 又会被读取到

List<MetricNode> metricNodes = searcher.find(1729965161000L, 5);

brucelwl avatar Oct 27 '24 05:10 brucelwl

@brucelwl , I have made a PR please have a look and let me know if any changes are required.

Thanks

manojks1999 avatar Oct 27 '24 17:10 manojks1999

@manojks1999 看着没什么问题

brucelwl avatar Oct 28 '24 04:10 brucelwl

@sczyh30 看下这个问题

brucelwl avatar Nov 13 '24 11:11 brucelwl