PhotonLibOS icon indicating copy to clipboard operation
PhotonLibOS copied to clipboard

Add more build options to get a separate lib, and the official release of 1.0

Open beef9999 opened this issue 2 years ago • 4 comments

TODO:

~~Separate Photon lib to thread, net, rpc ... libs.~~

  • Add more build options, for example, get thread lib alone
  • Add a build option for C++ standard. Photon now hardcoded C++14. Users with C++17 might fail because of std::string_view
  • Rename BUILD_TESTING to PHOTON_BUILD_TESTING option, in case of being overwrite by parent project
  • Hide symbols, for example, aio and curl . Expose libc and libc++ only
  • Support changing submodule URL in option, for example, a gitee repo instead of the github repo
  • Publish the official 1.0 release

beef9999 avatar Aug 09 '23 06:08 beef9999

Why the separation?

lihuiba avatar Aug 10 '23 06:08 lihuiba

I would suggest that:

  1. We provide build options to allow for output as static or dynamic lib, whether build individual modules, whether link the modules together, whether link dependencies, and whether hide the symbols of the dependencies.
  2. We release official pre-built binary libphoton.so that links together all dependencies (e.g. libcurl, libaio, etc.) statically, and hide their symbols inside libphoton.so to avoid potential conflicts with other libs.

lihuiba avatar Aug 14 '23 06:08 lihuiba

I would suggest that:

We provide build options to allow for output as static or dynamic lib, whether build individual modules, whether link the modules together, whether link dependencies, and whether hide the symbols of the dependencies.

We release official pre-built binary libphoton.so that links together all dependencies (e.g. libcurl, libaio, etc.) statically, and hide their symbols inside libphoton.so to avoid potential conflicts with other libs.

These would be great indeed.

medvednikov avatar Oct 06 '23 09:10 medvednikov

@beef9999 @Coldwings Let's split the goal and achieve the sub-goals gradually.

lihuiba avatar Oct 09 '23 05:10 lihuiba