GraphScope icon indicating copy to clipboard operation
GraphScope copied to clipboard

[FEATURE-287]:Session persistence and restore #287

Open bifenglin opened this issue 2 years ago • 2 comments

Signed-off-by: bifenglin [email protected]

What do these changes do?

Session persistence and restore, It includes session config and graph object.

Related issue number

#287

Fixes

bifenglin avatar Aug 25 '22 06:08 bifenglin

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Aug 25 '22 06:08 CLAassistant

Codecov Report

Merging #1986 (43fccc5) into main (bd8252f) will decrease coverage by 33.25%. The diff coverage is 2.91%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #1986       +/-   ##
===========================================
- Coverage   73.10%   39.85%   -33.26%     
===========================================
  Files          89       90        +1     
  Lines        9834     9937      +103     
===========================================
- Hits         7189     3960     -3229     
- Misses       2645     5977     +3332     
Impacted Files Coverage Δ
python/graphscope/client/test.py 0.00% <0.00%> (ø)
python/graphscope/tests/unittest/test_session.py 0.00% <0.00%> (-64.22%) :arrow_down:
python/graphscope/client/session.py 58.15% <5.08%> (-16.85%) :arrow_down:
python/graphscope/tests/unittest/test_java_app.py 0.00% <0.00%> (-100.00%) :arrow_down:
...ython/graphscope/tests/unittest/test_cython_ast.py 0.00% <0.00%> (-100.00%) :arrow_down:
...ython/graphscope/tests/unittest/test_serailaize.py 0.00% <0.00%> (-100.00%) :arrow_down:
python/graphscope/analytical/udf/patch.py 3.47% <0.00%> (-96.53%) :arrow_down:
python/graphscope/tests/unittest/test_lazy.py 0.00% <0.00%> (-96.30%) :arrow_down:
...thon/graphscope/tests/unittest/test_scalability.py 0.00% <0.00%> (-96.16%) :arrow_down:
python/graphscope/tests/unittest/test_app.py 0.00% <0.00%> (-95.66%) :arrow_down:
... and 42 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bd8252f...43fccc5. Read the comment docs.

codecov-commenter avatar Aug 28 '22 15:08 codecov-commenter

So, If there is any request or any problem with this PR. Plz remind me. And I will work on it until it has been satisfied. @siyuan0322

bifenglin avatar Feb 09 '23 08:02 bifenglin

So, If there is any request or any problem with this PR. Plz remind me. And I will work on it until it has been satisfied. @siyuan0322

Sorry for I'm thinking to drop that graph_list parameters so that it will automatically save all opened graphs, but that seems a little hard to implement, and while I'm thinking about the solution, my attention was drawn to other issues = =. I'll pick it up and get it merged ASAP this time.

siyuan0322 avatar Feb 14 '23 07:02 siyuan0322

So, If there is any request or any problem with this PR. Plz remind me. And I will work on it until it has been satisfied. @siyuan0322

Sorry for I'm thinking to drop that graph_list parameters so that it will automatically save all opened graphs, but that seems a little hard to implement, and while I'm thinking about the solution, my attention was drawn to other issues = =. I'll pick it up and get it merged ASAP this time.

Thanks for your reply. And I have known the request. I will follow the request in the issue so that it can clear the requirement.

bifenglin avatar Feb 14 '23 07:02 bifenglin