GraphScope icon indicating copy to clipboard operation
GraphScope copied to clipboard

[BUG] can't drop edge if edge's vertex drop first on GraphScope Store

Open iamdrq opened this issue 2 years ago • 7 comments

Describe the bug can't drop edge if accidentally drop edge's vertex first on GraphScope Store

To Reproduce 1.create vertexA 2.create edgeB relation vertexA 3.update 4.drop vertexA 5.update 6.drop edgeB (fail)

Expected behavior drop vertexA check vertexA relation edge

iamdrq avatar Aug 04 '22 13:08 iamdrq

Thanks for opening your first issue here! Be sure to follow the issue template! And a maintainer will get back to you shortly! Please feel free to contact us on DingTalk, WeChat account(graphscope) or Slack. We are happy to answer your questions responsively.

welcome[bot] avatar Aug 04 '22 13:08 welcome[bot]

Thanks for reporting! Could you paste the codes so I can get more clear about it. I think it should first drop e together with the src and dst, then drop e. for example:

schema.drop(E, A, A)
schema.drop(E)
schema.update()

Will make more clear and refine about the schema part later. https://github.com/alibaba/GraphScope/blob/1de75338949fbcf7733bdd27328ac4500204be6c/python/graphscope/framework/graph_schema.py#L521

siyuan0322 avatar Aug 05 '22 08:08 siyuan0322

I know should drop edge first according to doc. yes, I accidentally drop vertex first.

schema.drop(A)
schema.update()
schema.drop(E, A, A)
schema.update()

then can't drop E

iamdrq avatar Aug 05 '22 08:08 iamdrq

additional, I got exception when try load data from S3.

I found some key msg on coordinator pod ( I use GraphScope 0.15.0 on k8s ):

extra diagnostics are as follows: Cannot find such files for 's3://minio.cdst.svc.cluster.local/graph/v.csv'
/tmp/arrow-apache-arrow-1.0.1/cpp/src/arrow/result.cc:28: /tmp/arrow-apache-arrow-1.0.1/cpp/src/arrow/result.cc:28: ValueOrDie called on an error: NotImplemented: Got S3 URI but Arrow compiled without S3 supportValueOrDie called on an error: NotImplemented: Got S3 URI but Arrow compiled without S3 support

How install with S3 support ?

iamdrq avatar Aug 05 '22 08:08 iamdrq

Should be a bug and needs a patch.

sighingnow avatar Aug 05 '22 08:08 sighingnow

Should be a bug and needs a patch.

We have to two possible solutions:

  • upgrade the arrow version in the graphscope-runtime image and enables the S3 support when building arrow
  • delegate s3 IO to vineyard-io module

sighingnow avatar Aug 05 '22 08:08 sighingnow

I know should drop edge first according to doc. yes, I accidentally drop vertex first.

schema.drop(A)
schema.update()
schema.drop(E, A, A)
schema.update()

then can't drop E

OK~ Then it's a bug. We shouldn't let the vertex be dropped as long as there is a edge related with it. Will be fixed later. Thanks!

siyuan0322 avatar Aug 05 '22 09:08 siyuan0322