FederatedScope icon indicating copy to clipboard operation
FederatedScope copied to clipboard

Incorrect arguments to SHAWrapFedex init method

Open krishnakanthnakka opened this issue 2 years ago • 1 comments

It seems like the SHAWrapFedex missed to take client_cfgs. Please check.

The Line https://github.com/alibaba/FederatedScope/blob/7f0af2d7aa1537b1a033f4817fbdb62b44e10ac6/federatedscope/autotune/algos.py#L65

    elif init_cfg.hpo.scheduler.startswith('wrap', client_cfgs):
        scheduler = SHAWrapFedex(init_cfg)

perhaps to be changed to

    elif init_cfg.hpo.scheduler.startswith('wrap'):
        scheduler = SHAWrapFedex(init_cfg, client_cfgs)

krishnakanthnakka avatar Sep 06 '23 13:09 krishnakanthnakka

Thanks for the catching! The SHAWrapFedex will be deprecated in the future in #518 , but for now, adding client_cfgs is the correct solution to avoid errors.

rayrayraykk avatar Sep 11 '23 01:09 rayrayraykk