AndFix apkpatch.jar工具中，类DexDiffer可能有误

apkpatch.jar工具中，类DexDiffer可能有误

Open withparadox2 opened this issue 8 years ago • 5 comments

    public DiffInfo diff(File newFile, File oldFile) throws IOException {
        ...
        boolean contains = false;
        for (DexBackedClassDef newClazz : newDexFile.getClasses()) {
            for (DexBackedClassDef oldClazz : oldDexFile.getClasses()) {
                if (newClazz.equals(oldClazz)) {
                    compareField(newClazz, oldClazz, info);
                    compareMethod(newClazz, oldClazz, info);
                    contains = true;
                    break;
                }
            }
            if (!contains) {
                info.addAddedClasses(newClazz);
            }
        }
        return info;
    }

如果contains第一次变为true，info.addAddedClasses(newClazz);就再也得不到执行。应该将boolean contains = false;移动到第一个for块里面。