next icon indicating copy to clipboard operation
next copied to clipboard

fix(Badge): resolve Badge component position is incorrect when the child is a block element, close #3084

Open edc-hui opened this issue 2 years ago • 7 comments

修复Badge的children为块级元素时,角标的位置异常的问题

edc-hui avatar Sep 06 '22 09:09 edc-hui

@lakerswgq 你好,github cli环境,报date-picker2组件的测试用例不通过。

我目前在本地无论是执行npm run test 还是 npm run test date-pick2均是通过的。

请问这个该怎么处理?之前我提过相关的issue #4086 。那个时候 date-pick2测试用例不通过发生在我本地,现在本地能够通过了,github cli却不能通过了。

edc-hui avatar Sep 06 '22 09:09 edc-hui

报错截图如下: image

edc-hui avatar Sep 06 '22 09:09 edc-hui

我帮你重跑下。这个测试写法不太稳定

lakerswgq avatar Sep 07 '22 05:09 lakerswgq

修复Badge的children为块级元素时,角标的位置异常的问题

这个有出问题的 demo 吗,我看下问题表现

lakerswgq avatar Sep 07 '22 05:09 lakerswgq

Codecov Report

Base: 90.56% // Head: 90.56% // No change to project coverage :thumbsup:

Coverage data is based on head (4e57a0b) compared to base (64777e1). Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4092   +/-   ##
=======================================
  Coverage   90.56%   90.56%           
=======================================
  Files         306      306           
  Lines       17942    17942           
  Branches     5407     5407           
=======================================
  Hits        16249    16249           
  Misses       1672     1672           
  Partials       21       21           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Sep 07 '22 05:09 codecov[bot]

@lakerswgq 官网Badge组件,手动改下Badge的children的display: block,可以直接复现, image

edc-hui avatar Sep 07 '22 05:09 edc-hui

明白了,我得看下影响面。目前有问题可以先 inline-block

lakerswgq avatar Sep 20 '22 02:09 lakerswgq

抱歉,项目正在重构,还未合并PR因此关闭了,有需要可以重新基于master提交PR~

YSMJ1994 avatar Dec 27 '23 07:12 YSMJ1994