RVSS icon indicating copy to clipboard operation
RVSS copied to clipboard

Conflict with documentation.

Open glerapic opened this issue 5 years ago • 1 comments

According to the RVSS whitepaper on section 4C RVSS v1.0 Specification table 4 (page 21) the entry safety reads as follows: Screenshot from 2020-03-20 12-12-25

so when i run the argument HU on safety i get the following:

alfonso@alias:~$ rvss RVSS:1.0/AV:RN/AC:H/PR:N/UI:N/Y:Z/S:C/C:H/I:H/A:H/H:HU
Error parsing vector: Unknown vector key 'hu' for SafetyImpact

When i run H instead of HU, runs smoothly.

alfonso@alias:~$ rvss RVSS:1.0/AV:RN/AC:H/PR:N/UI:N/Y:Z/S:C/C:H/I:H/A:H/H:H
Base Score:	8.4
Temporal:	8.4
Environment:	8.4

i suggest changing the code to be consistent with the documentation.

glerapic avatar Mar 20 '20 11:03 glerapic

Good one. Should be one letter, that's a mistake in the article then.

We should probably reflect this here in the repo by making a changelog/ERRATA section. Thanks for this @glerapic

vmayoral avatar Mar 20 '20 11:03 vmayoral