scrumblr icon indicating copy to clipboard operation
scrumblr copied to clipboard

Add markdown support

Open ldidry opened this issue 9 years ago • 4 comments

With the help of marked

ldidry avatar Sep 14 '16 21:09 ldidry

This code works pretty great. I integrated it into 0.5 of the Sandstorm.io package of Scrumblr. I just had to grab some changes for marked.min.js to make links open in a new tab so that they'd work with Sandstorm's sandboxing: https://github.com/ocdtrekkie/scrumblr/commit/6acde8587a6b934997cb324e71a78640812d3618 (This contains a hacked-together version of marked.js with a PR the marked.js author refused to merge from another user.)

It may be noteworthy that this functionality may be better outside Sandstorm as well. I doubt people who click links on their Kanban want to open them in the same tab.

ocdtrekkie avatar Jan 18 '17 05:01 ocdtrekkie

This PR should include the security fix of this issue when it will be ready (this is confidential for now).

Framartin avatar May 12 '17 19:05 Framartin

@ldidry Can you include the fix to this XSS in this MR.

@ocdtrekkie I have created a MR in your repo to fix the Sandstorm version: https://github.com/ocdtrekkie/scrumblr/pull/11

Framartin avatar Jul 06 '17 00:07 Framartin

@Framartin Done.

ldidry avatar Jul 10 '17 07:07 ldidry