Noto icon indicating copy to clipboard operation
Noto copied to clipboard

Search in notes

Open alialbaali opened this issue 2 years ago • 2 comments

This feature would allow you to search specific words in notes. You would be able to cycle though them, just like in browsers.

alialbaali avatar Jul 31 '22 21:07 alialbaali

That's great and on my wishlist, too. Do you think it's possible to search through a folder and open single findings and then have the search term still marked, without initiating a new search inside the note? That'd be really awesome!

uli-on avatar Aug 01 '22 16:08 uli-on

I think one of the open source apps it has is Neutrinote.

uli-on avatar Aug 01 '22 18:08 uli-on

That's great and on my wishlist, too. Do you think it's possible to search through a folder and open single findings and then have the search term still marked, without initiating a new search inside the note? That'd be really awesome!

That's definitely something I'd do when supporting search in notes.

alialbaali avatar May 02 '23 21:05 alialbaali

@uli-on

Spoiler Alert This feature will be supported in 2.3.0. Stay tuned for the beta!

alialbaali avatar May 05 '23 00:05 alialbaali

Any suggestions regarding this feature?

alialbaali avatar Jun 02 '23 20:06 alialbaali

Generally I'm very happy that Noto has a more comprehensive search, now :)

If that's possible, though, technically, and only because you asked: Initiating a search from one of the virtual folders (All, Recent, Scheduled, Archived) would be most helpful for situations where one can't remember at all where one's written on certain topics, was it the "News" folder, the "General Software Dump", "Security" or one of the specific app related ones, and which of these 17? I know, searching is possible from these, but I have to start a new search inside each result, time and again.

One small concern is the use of folder colour for highlighting search terms. Currently, there are two folder colours making it hard to spot the search results, the pure white in the dark theme, (which parallels the pure black in the white theme), and esp. the light gray. Hence, if this is technically possible I'd be for applying a background colour to search terms like used for word selection.

Oh, and if the transparent space between the search field and the keyboard (Noto toolbar, respectively) could be minimised (maybe full width for design reasons), that would be awesome. Try a dark theme where you have no search box shadow for making the distance aesthetically appealing, then while scrolling you have the content flickering through between these elements which is both unattractive and distracting.

uli-on avatar Jun 05 '23 22:06 uli-on

If that's possible, though, technically, and only because you asked: Initiating a search from one of the virtual folders (All, Recent, Scheduled, Archived) would be most helpful for situations where one can't remember at all where one's written on certain topics, was it the "News" folder, the "General Software Dump", "Security" or one of the specific app related ones, and which of these 17? I know, searching is possible from these, but I have to start a new search inside each result, time and again.

I missed implementing this. But, it's going to be in the next beta.

One small concern is the use of folder colour for highlighting search terms. Currently, there are two folder colours making it hard to spot the search results, the pure white in the dark theme, (which parallels the pure black in the white theme), and esp. the light gray. Hence, if this is technically possible I'd be for applying a background colour to search terms like used for word selection.

Great suggestion! I'll work on it now.

Oh, and if the transparent space between the search field and the keyboard (Noto toolbar, respectively) could be minimised (maybe full width for design reasons), that would be awesome. Try a dark theme where you have no search box shadow for making the distance aesthetically appealing, then while scrolling you have the content flickering through between these elements which is both unattractive and distracting.

As for this, could you please create another issue? It'd be for me to better understand it, and fix it, since I tried what you said, and I definitely see some problems.

Thank you!

alialbaali avatar Jun 06 '23 18:06 alialbaali

IMAGE 2023-06-06 14:40:46

Thoughts?

alialbaali avatar Jun 06 '23 18:06 alialbaali

I've not been mailed that last post, I come here by incident. I hope that's been an outlier.

Visibility is sufficient :) Is this meant for only the 2-3 special cases I named or is it intended to generally replace the coloured letters, i.e. for all folder colours?

From the graphic design POV, the padding-bottom on these spans might be reduced a little, so they don't touch each other.

uli-on avatar Jun 07 '23 20:06 uli-on

These are only meant for light gray & black colors, where it's hard to see the highlighted text. The rest will not change.

I'll try to reduce the bottom padding, however, I'm not sure if I'd be able to, since this is Android Framework specific.

alialbaali avatar Jun 08 '23 17:06 alialbaali

IMAGE 2023-06-08 19:28:14

So, I was able to modify the padding, and the background. I made the corners a bit rounded too. However, a slight issue arose which is, the cursor is almost invisible next to the highlighted text.

alialbaali avatar Jun 08 '23 23:06 alialbaali

the cursor is almost invisible next to the highlighted text.

But the cursor is flashing, at least here. Would have to test, probably. Mostly for seeing how the coloured span reacts if you put the cursor right into the span.

One idea: Does the framework enforce using the same colour for cursor and background? If not, you could set the background to - say - 60-70% intensity, which should be visible enough and set the cursor a little apart, colour-wise

uli-on avatar Jun 09 '23 16:06 uli-on

Since I was able to modify the background, I can adjust the opacity to be less. However, I will keep it as is for the next beta.

alialbaali avatar Jun 10 '23 01:06 alialbaali

I discovered a bug while implementing this, regarding cursors being in two places at the same time (idk how 🥲). So, I decided to highlight the current word differently.

Examples: IMAGE 2023-06-10 22:29:24

IMAGE 2023-06-10 22:29:28

alialbaali avatar Jun 11 '23 02:06 alialbaali

While we're at it, what do you think about words count being displayed on each note when searching in a folder?

IMAGE 2023-06-10 22:55:50

alialbaali avatar Jun 11 '23 02:06 alialbaali

So, I decided to highlight the current word differently.

Frankly, that's the most visible, most usable version! If it could be done like that for the coloured versions, too, that'd be great!

uli-on avatar Jun 11 '23 18:06 uli-on

words count [...] on each note when searching in a folder

For some use cases this might be helpful. But I'd make its visibility pref dependent cause at first glance it doesn't add to the clarity, the conceivableness of the results page and so might be undesired to some. But after some searches and familiarisation, "why not switch it on?"

uli-on avatar Jun 11 '23 18:06 uli-on

words count [...] on each note when searching in a folder

For some use cases this might be helpful. But I'd make its visibility pref dependent cause at first glance it doesn't add to the clarity, the conceivableness of the results page and so might be undesired to some. But after some searches and familiarisation, "why not switch it on?"

Understandable. I'll remove it for now, until I come up with a better design.

alialbaali avatar Jun 11 '23 19:06 alialbaali

So, I decided to highlight the current word differently.

Frankly, that's the most visible, most usable version! If it could be done like that for the coloured versions, too, that'd be great!

Wonderful! I'll update the colored versions as you suggested :)

alialbaali avatar Jun 11 '23 19:06 alialbaali

2.3.0-Beta2 has been released, any thoughts?

alialbaali avatar Jul 13 '23 18:07 alialbaali

Thanks for the reminder, will have an opportunity at the weekend.

uli-on avatar Jul 14 '23 11:07 uli-on

The search is great now!! I've always hoped to have this kind of continued search in a notes app, from the notes list (and even better like now in Noto: from one level above, i.e. starting from the "General" folder) and have the results displayed not only in the notes list, but inside the single note, be able to jump from result to result, go back to the notes list, all my results still there, open the next note, and so on. And all that combined with the label filtering and hierarchical folders is a-w-e-s-o-m-e for putting and retrieving(!!) all kinds of miscellaneous stuff with ease!!

uli-on avatar Jul 15 '23 22:07 uli-on

Really glad you like it!

alialbaali avatar Jul 16 '23 04:07 alialbaali