Noto icon indicating copy to clipboard operation
Noto copied to clipboard

Published 20 hours ago • verified publisher icon alialbaali

TickerView suffers from inversion and disintegration of Arabic text in the archive window

Open AI-IMED opened this issue 2 years ago • 13 comments

TickerView animation is not disabled in the archive window when the language is Arabic, in v2.2.0-Beta1 Excuse Ali, what about: https://github.com/alialbaali/Noto/issues/50#issuecomment-1193678346

AI-IMED avatar Aug 26 '22 14:08 AI-IMED

TickerView animation is fixed now.

About #50, it should already detect if the device language (not the app) is Arabic.

alialbaali avatar Aug 27 '22 15:08 alialbaali

About #50, it should already detect if the device language (not the app) is Arabic

I didn't see it in v2.2.0-Beta1

AI-IMED avatar Aug 27 '22 17:08 AI-IMED

#121 Fixed it, Thanks

https://github.com/alialbaali/Noto/issues/50#issuecomment-1193678346
Fixed it, But On the other hand, this resulted in a loss of tilting for creation/access date text, and animations in TickerView for the other languages ​​when manually selected.

AI-IMED avatar Sep 12 '22 06:09 AI-IMED

On the other hand, this resulted in a loss of tilting for creation/access date text, and animations in TickerView for the other languages ​​when manually selected.

When changing app language or device language?

alialbaali avatar Sep 12 '22 11:09 alialbaali

App language

AI-IMED avatar Sep 12 '22 11:09 AI-IMED

Other languages work fine for me. Could you please share a screen record?

alialbaali avatar Sep 13 '22 11:09 alialbaali

Sure

https://user-images.githubusercontent.com/38974362/189896957-665b3623-e92d-4b1b-aa51-e7479f1d0bab.mp4

AI-IMED avatar Sep 13 '22 12:09 AI-IMED

The current implementation depends on the device language and not the app language, like you suggested in https://github.com/alialbaali/Noto/issues/50#issuecomment-1193678346.

How do you think the implementation or the condition should be valued, then?

alialbaali avatar Sep 13 '22 12:09 alialbaali

Condition: When the device language is Arabic only.

AI-IMED avatar Sep 13 '22 12:09 AI-IMED

Isn't that already the case?

alialbaali avatar Sep 13 '22 12:09 alialbaali

No, this is not the case, I do not want to lose the tilt of the text and animation in the TickerView when I choose the language of the application English

AI-IMED avatar Sep 13 '22 12:09 AI-IMED

If the device language is set to Arabic, this would override any app language. As I am checking for the device language only.

I think one condition might work, is that if I check if app language is Arabic or Follow System, and device language is Arabic too. That might resolve this issue.

alialbaali avatar Sep 13 '22 12:09 alialbaali

I think one condition might work, is that if I check if app language is Arabic or Follow System, and device language is Arabic too. That might resolve this issue

Great!, problem solved, Thanks.

AI-IMED avatar Oct 02 '22 12:10 AI-IMED