Ali Akbar Azizi

Results 38 comments of Ali Akbar Azizi

I did check some of the test there is two main issue one of them checking how many re-render call and it expect `2` but because of fetchedPages is `3`...

In this test It's expected, in this test we fetch 3 pages and after all of that we refetch all pages again, so we fetch 6 pages, and we have...

Actually you are right, in the test we don't call `fetchedPages` I will check it soon

> > one of them checking how many re-render call and it expect 2 but because of fetchedPages is 3 now I think I just need change 2 to 3...

> there's one more react-query tests that needs changes: > > ``` > FAIL packages/react-query/src/__tests__/useInfiniteQuery.test.tsx > ● useInfiniteQuery › should return the correct states for a successful query > >...

I did merge `meta` with `fetchMeta`, I also fixed tests and add one test specifically for `fetchedPages`. I have weird problem in local with `userQuery` tests. I pushed my code...

> I took a look at this PR. It seems like most (all?) solid tests fail because `solid-query` resolves `queryObserver` updates a little differently than `react-query`. Take a look at...

@ardeora shouldn't `tracked` works fine in solid? if it's working then we shouldn't have any state changes because there is no subscribe to `fetchedPages` in those tests. Also I don't...

@ardeora @TkDodo any updates?

@TkDodo I did answered all of them before. I don't know my answer is enough or need an action to fix them