ali-rds icon indicating copy to clipboard operation
ali-rds copied to clipboard

feat:add logger support

Open jtyjty99999 opened this issue 7 years ago • 6 comments

https://github.com/eggjs/egg/issues/648

jtyjty99999 avatar Mar 26 '17 15:03 jtyjty99999

@jtyjty99999, thanks for your PR! By analyzing the history of the files in this pull request, we identified @fengmk2, @csbun and @fangk to be potential reviewers.

mention-bot avatar Mar 26 '17 15:03 mention-bot

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@e8d8056). Click here to learn what that means. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #18   +/-   ##
=========================================
  Coverage          ?   98.94%           
=========================================
  Files             ?        6           
  Lines             ?      285           
  Branches          ?       41           
=========================================
  Hits              ?      282           
  Misses            ?        3           
  Partials          ?        0
Impacted Files Coverage Δ
lib/client.js 95.38% <100%> (ø)
lib/operator.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e8d8056...20bc782. Read the comment docs.

codecov-io avatar Mar 30 '17 09:03 codecov-io

参照 https://github.com/eggjs/egg/issues/235 模式实现吧。

fengmk2 avatar Mar 30 '17 09:03 fengmk2

@fengmk2 只暴露request和response事件?

jtyjty99999 avatar Mar 30 '17 09:03 jtyjty99999

logger 基于这两个事件来打印,如果配置了开启 logger,就打印sql 执行时间

fengmk2 avatar Mar 30 '17 09:03 fengmk2

ping @jtyjty99999 这个怎么样了

atian25 avatar Jun 05 '18 07:06 atian25

https://github.com/ali-sdk/ali-rds/pull/104

fengmk2 avatar Mar 05 '23 01:03 fengmk2