org-special-block-extras icon indicating copy to clipboard operation
org-special-block-extras copied to clipboard

Dependency from string library (s) version 1.12.0 I believe its wrong

Open azynheira opened this issue 3 years ago β€’ 4 comments

I have installed org-special-block-extras (both version 2 and the latest 20210806.154) and they state that one of their dependencies is s-1.12.0 as per (;; Package-Requires: ((s "1.12.0") (dash "2.18.0") (emacs "26.1") (org "9.1"))).

The problem here is they required a function called 's-replace-regexp' which is not present in version 1.12.0 (which I installed from MELPA-STABLE) but at least on the latest version in MELPA (20210616.619). That one worked for me.

This is not a huge issue but it needs to be stated somewhere that the correct version of the dependency.

azynheira avatar Aug 12 '21 10:08 azynheira

@azynheira Would you please make a pull request for the suggested change 😁

alhassy avatar Dec 30 '21 01:12 alhassy

Geez I totally forgot about this😁 Let me give it a try.

Pedro

On Thu, 30 Dec 2021, 01:56 Musa Al-hassy, @.***> wrote:

@azynheira https://github.com/azynheira Would you please make a pull request for the suggested change 😁

β€” Reply to this email directly, view it on GitHub https://github.com/alhassy/org-special-block-extras/issues/14#issuecomment-1002840104, or unsubscribe https://github.com/notifications/unsubscribe-auth/AACUVHG6AKT3IUBQTBWI54LUTO36JANCNFSM5CA3DRAQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you were assigned.Message ID: @.***>

azynheira avatar Dec 30 '21 05:12 azynheira

Since the author of the s-library has not released anything after 1.12. I will do a pull request just making a small fix so that library function is available.

azynheira avatar May 24 '22 13:05 azynheira

That sounds awesome; thank-you!

alhassy avatar May 25 '22 01:05 alhassy

@azynheira Thank-you for your efforts; this issue has now been resolved πŸ₯³

alhassy avatar Jul 14 '23 01:07 alhassy