langpacks icon indicating copy to clipboard operation
langpacks copied to clipboard

RunnerOutput error type does not match langpack guide specification

Open zeryx opened this issue 5 years ago • 1 comments

The RunnerOutput object is defined here: https://github.com/algorithmiaio/langpacks/blob/b35efaa7d69d24efcd83e866b7445446f92eb0d6/src/message.rs#L16

The Output section of bin/pipe makes no mention of an error key: https://github.com/algorithmiaio/langpacks/blob/master/langpack_guide.md#binpipe

In the existing Python runtime, you can see a encapsulating error key that wraps the error object, here: https://github.com/algorithmiaio/langpacks/blob/master/libraries/python3-runtime/context/pipe#L66-L77

zeryx avatar Mar 06 '19 16:03 zeryx

this is a bug in documentation - feel free to update the langpack_guide.md

pmcq avatar Mar 06 '19 16:03 pmcq