algorithm-archive icon indicating copy to clipboard operation
algorithm-archive copied to clipboard

insertion-sort-chapter

Open GuyPozner opened this issue 6 years ago • 7 comments

Hi, Ive created an insertion sort chapter, hope you'll like it. I'll add more languages soon.

GuyPozner avatar Jul 04 '18 18:07 GuyPozner

Hey @GuyPozner Thanks for the submission and for writing the insertion sort chapter! I would like to use this PR as a test-case to see how the submission of chapter text can work, so give me a little while to do a review and some digging on my side. In general, I try to let my own chapter PR's stay up for about a week for comments and such from the community, so expect a similar timeframe here. The chapter looks fine at first glance, and insertion sort doesn't build into too many algorithms (that I know of), so it's a good algorithm to test chapter submissions with.

That said, I might be a little harsh on the text at places and ask for a lot more detail in certain areas.

leios avatar Jul 04 '18 23:07 leios

Any updates here?

GuyPozner avatar Jul 24 '18 08:07 GuyPozner

Unfortunately not. I haven't had the time to study insertion sort, but should have time this weekend. We are still kinda new to the text-reviewing, so I have a few chapters I need to look at.

I am sorry it's taking so long! Thanks for finishing the py monte carlo stuff, by the way.

leios avatar Jul 24 '18 09:07 leios

[lang: c]

ntindle avatar Aug 28 '21 05:08 ntindle

[lang: python]

ntindle avatar Aug 28 '21 05:08 ntindle

@leios Do we still want to have this PR open, since we removed the sorting chapters from the AAA? We could still re-open it later, when we decide to add them again

Amaras avatar Oct 26 '21 19:10 Amaras

I'm actually not sure what to do with this PR. I think I am happy to add sorting and searching chapters, so long as they are community-contributed. That means this PR is still on the table if @GuyPozner is still willing to help with it (after taking a few years to get back to them)

leios avatar Nov 07 '21 17:11 leios