js-algorand-sdk icon indicating copy to clipboard operation
js-algorand-sdk copied to clipboard

Added a new example.

Open Bhaney44 opened this issue 2 years ago • 1 comments

Following up on PR #646 Choice Connect, which was rejected for lack of showcasing the Javascript-SDK enough relative to Pera Wallet. I created a new example, which does more to showcase the capabilities of the JavaScript-SDK by creating a game where a user wins a prize. This contribution is made in response to Issue #150 on the Algorand Foundation GitHub.

Bhaney44 avatar Sep 13 '22 19:09 Bhaney44

Hi, @jasonpaulos I hope all is well. I wanted to request a review on this please.

With thanks,

Brian

Bhaney44 avatar Sep 22 '22 04:09 Bhaney44

Hi @jasonpaulos I hope all is well. Just wanted to follow up on this.

Thanks,

Brian

Bhaney44 avatar Oct 02 '22 17:10 Bhaney44

Hi @Bhaney44, thanks for the effort here but this is not something that really belongs in the SDK itself for a number of reasons including; new dependencies, support effort required, and branded or licensed content.

Perhaps consider a blog post on medium?

In the future a good way to go about this would be to file an Issue first where the idea and scope of work can be discussed before starting on anything.

barnjamin avatar Oct 07 '22 13:10 barnjamin

Issue #150

Hi Ben, Thanks for the reply. I will file an Issue first in the future before making a PR.

Regarding the license however, Issue 150 expressly requires contributions have an attributed license.

All project codes should be published on GitHub, with MIT license or Apache V2 license.

Bhaney44 avatar Oct 07 '22 13:10 Bhaney44

Hi @Bhaney44, thanks for the effort here but this is not something that really belongs in the SDK itself for a number of reasons including; new dependencies, support effort required, and branded or licensed content.

Perhaps consider a blog post on medium?

In the future a good way to go about this would be to file an Issue first where the idea and scope of work can be discussed before starting on anything.

I wanted to follow up on this @barnjamin. I went to open an Issue for a new contribution, but the only issues available to be opened are bug reports and feature requests. Given Algorand Foundation Issue 150, how would you like me to proceed with making contributions? Thanks.

Bhaney44 avatar Oct 08 '22 21:10 Bhaney44