java-algorand-sdk
java-algorand-sdk copied to clipboard
Client#getHttpUrl misbehaving?
Subject of the issue
I'm making a simple transactions lookup with the v2 indexer, via algoexplorer's access point. In the example code, the request url is printed, and it works fine in the browser. However, the request always 404's when made through the sdk.
Your environment
OpenJDK 17.0.2
Steps to reproduce
import com.algorand.algosdk.crypto.Address;
import com.algorand.algosdk.v2.client.common.IndexerClient;
import com.algorand.algosdk.v2.client.common.Response;
import com.algorand.algosdk.v2.client.indexer.LookupAccountTransactions;
import com.algorand.algosdk.v2.client.model.Transaction;
import com.algorand.algosdk.v2.client.model.TransactionsResponse;
public class Main {
public static void main(String[] args) throws Exception {
String host = "https://algoindexer.algoexplorerapi.io/";
int port = 443;
IndexerClient indx = new IndexerClient(host, port, "");
Address one = new Address("KX6S647W6BEN6XHEJVMXK3UYLVNGT2Q6PHQSF5AA2JSSDFSOX7R4MESXRY");
LookupAccountTransactions lookup = indx.lookupAccountTransactions(one).limit(10l);
System.out.println(lookup.getRequestUrl());
Response<TransactionsResponse> resp = lookup.execute();
if (!resp.isSuccessful()) {
System.out.println("Response code: "+resp.code()+" "+resp.message());
return;
}
for (Transaction t : resp.body().transactions) {
System.out.println(t.id);
}
}
}
Expected behaviour
The program should print the same json as the browser, when accessing the printed request url
Actual behaviour
The program always prints response code 404, even though the printed request url works in the browser.
Example output:
https://algoindexer.algoexplorerapi.io/v2/accounts/KX6S647W6BEN6XHEJVMXK3UYLVNGT2Q6PHQSF5AA2JSSDFSOX7R4MESXRY/transactions?limit=10
Response code: 404 {"message":"Not Found"}
Process finished with exit code 0
Also, when debugging it is revealed that Client#getHttpUrl constructs a url that repeats itself, see attached image
We should have reviewed and merged in the PR: https://github.com/algorand/java-algorand-sdk/pull/304/files