Quality: Switch from golint to golangci-lint.

[winder]

Summary

Future tasks:

• Install custom partitiontest linter.
• Move logic from .github/workflows/reviewdog.yml into Makefile
• push back new-from-rev

Test Plan

CI passes.

[codecov[bot]]

Codecov Report

Merging #4418 (f40ca28) into master (2848e37) will increase coverage by 0.00%. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #4418   +/-   ##
=======================================
  Coverage   55.25%   55.25%           
=======================================
  Files         398      398           
  Lines       50148    50148           
=======================================
+ Hits        27709    27711    +2     
- Misses      20127    20128    +1     
+ Partials     2312     2309    -3     

Impacted Files	Coverage Δ
ledger/tracker.go	73.93% <0.00%> (-0.86%)	:arrow_down:
ledger/acctupdates.go	69.29% <0.00%> (-0.60%)	:arrow_down:
network/wsPeer.go	70.41% <0.00%> (-0.28%)	:arrow_down:
catchup/service.go	69.38% <0.00%> (+0.49%)	:arrow_up:
catchup/peerSelector.go	100.00% <0.00%> (+1.04%)	:arrow_up:
ledger/blockqueue.go	88.50% <0.00%> (+2.87%)	:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

[gmalouf]

I think linter can be a GitHub action

On Tue, Aug 16, 2022 at 9:05 AM John Jannotti @.***> wrote:

@.**** commented on this pull request.

In .golangci.yml https://github.com/algorand/go-algorand/pull/4418#discussion_r946753067:

@@ -17,7 +17,9 @@ severity:

issues:

use these new lint checks on code since #2574

• new-from-rev: eb019291beed556ec6ac1ceb4a15114ce4df0c57

• #new-from-rev: eb019291beed556ec6ac1ceb4a15114ce4df0c57

• use stricter enforcement since ##4410

• new-from-rev: fd488f806dcbc2586f585155eea0180c30287f70

--new-from-rev REV seems to do it at the CLI

— Reply to this email directly, view it on GitHub https://github.com/algorand/go-algorand/pull/4418#discussion_r946753067, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAHP3U7SCF3BINHZ2O6DKJLVZOGZPANCNFSM56VQSF3Q . You are receiving this because your review was requested.Message ID: @.***>

[winder]

I think linter can be a GitHub action

It's also a github action, yes. This change aligns development with CI.