go-algorand icon indicating copy to clipboard operation
go-algorand copied to clipboard

prefetcher: enable prefetcher for assets and apps

Open algorandskiy opened this issue 2 years ago • 3 comments

Summary

Enable prefetcher for asset and app transactions except the foreign fields.

Test Plan

  1. Modified all prefetcher error tests to ensure all transaction groups returned by the prefetecher even in case errors.
  2. Checked prefetcher_alignment_test that validates prefetcher's behavior againsy apply logic.

algorandskiy avatar Aug 04 '22 00:08 algorandskiy

Codecov Report

Merging #4352 (6bdb584) into master (7e8ca90) will increase coverage by 0.06%. The diff coverage is 67.64%.

@@            Coverage Diff             @@
##           master    #4352      +/-   ##
==========================================
+ Coverage   54.11%   54.18%   +0.06%     
==========================================
  Files         401      401              
  Lines       51549    51583      +34     
==========================================
+ Hits        27898    27952      +54     
+ Misses      21311    21282      -29     
- Partials     2340     2349       +9     
Impacted Files Coverage Δ
ledger/internal/eval.go 67.15% <8.57%> (-0.69%) :arrow_down:
ledger/internal/prefetcher/prefetcher.go 95.51% <98.50%> (+27.32%) :arrow_up:
ledger/roundlru.go 90.56% <0.00%> (-5.67%) :arrow_down:
network/wsPeer.go 66.03% <0.00%> (-4.86%) :arrow_down:
ledger/blockqueue.go 85.63% <0.00%> (-2.88%) :arrow_down:
crypto/merkletrie/trie.go 66.42% <0.00%> (-2.19%) :arrow_down:
crypto/merkletrie/node.go 91.62% <0.00%> (-1.87%) :arrow_down:
catchup/peerSelector.go 98.95% <0.00%> (-1.05%) :arrow_down:
catchup/service.go 68.14% <0.00%> (-0.50%) :arrow_down:
network/wsNetwork.go 64.82% <0.00%> (ø)
... and 3 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Aug 04 '22 00:08 codecov[bot]

ops, broke some asset receiver prefetching, fixing

algorandskiy avatar Sep 15 '22 20:09 algorandskiy

Fixed one unit test and adjusted AssetReceiver prefetching condition.

algorandskiy avatar Sep 16 '22 16:09 algorandskiy

Thank you for review! I'll merge it right after the boxes go through to prevent possible conflicts.

algorandskiy avatar Oct 24 '22 21:10 algorandskiy