go-algorand icon indicating copy to clipboard operation
go-algorand copied to clipboard

AVM: Add Multi-byte Opcodes

Open iten-alg opened this issue 3 years ago • 2 comments

Summary

Test Plan

iten-alg avatar Jul 27 '22 14:07 iten-alg

Codecov Report

Merging #4309 (0182490) into master (3eff232) will decrease coverage by 0.03%. The diff coverage is 72.47%.

@@            Coverage Diff             @@
##           master    #4309      +/-   ##
==========================================
- Coverage   55.29%   55.25%   -0.04%     
==========================================
  Files         395      395              
  Lines       50334    50411      +77     
==========================================
+ Hits        27831    27856      +25     
- Misses      20111    20165      +54     
+ Partials     2392     2390       -2     
Impacted Files Coverage Δ
data/transactions/logic/doc.go 46.66% <ø> (-14.88%) :arrow_down:
data/transactions/logic/assembler.go 84.87% <70.58%> (-0.22%) :arrow_down:
data/transactions/logic/opcodes.go 76.01% <71.95%> (-7.86%) :arrow_down:
data/transactions/logic/eval.go 89.47% <80.00%> (-0.05%) :arrow_down:
cmd/algoh/blockWatcher.go 77.77% <0.00%> (-3.18%) :arrow_down:
node/node.go 23.01% <0.00%> (-2.39%) :arrow_down:
ledger/tracker.go 76.29% <0.00%> (-1.73%) :arrow_down:
catchup/service.go 68.88% <0.00%> (-1.24%) :arrow_down:
catchup/peerSelector.go 98.95% <0.00%> (-1.05%) :arrow_down:
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

codecov[bot] avatar Jul 29 '22 21:07 codecov[bot]

Pretty sure the benchmark issues the ci is reporting are from the bls opcodes being version 8, but their tests using version 7, but I'll look more into it

iten-alg avatar Aug 01 '22 18:08 iten-alg