go-algorand icon indicating copy to clipboard operation
go-algorand copied to clipboard

Catchpoint: Optimize catchpoint

Open nicholasguoalgorand opened this issue 2 years ago • 1 comments

Summary

Test Plan

nicholasguoalgorand avatar Jul 12 '22 16:07 nicholasguoalgorand

Codecov Report

Merging #4254 (cfa250d) into master (e4d6d42) will increase coverage by 0.09%. The diff coverage is 72.13%.

@@            Coverage Diff             @@
##           master    #4254      +/-   ##
==========================================
+ Coverage   55.19%   55.28%   +0.09%     
==========================================
  Files         398      398              
  Lines       50165    50263      +98     
==========================================
+ Hits        27689    27789     +100     
- Misses      20159    20162       +3     
+ Partials     2317     2312       -5     
Impacted Files Coverage Δ
ledger/catchupaccessor.go 62.15% <56.36%> (-0.87%) :arrow_down:
ledger/accountdb.go 73.02% <75.45%> (+0.44%) :arrow_up:
ledger/catchpointtracker.go 62.89% <100.00%> (ø)
ledger/catchpointwriter.go 59.13% <100.00%> (+1.47%) :arrow_up:
ledger/tracker.go 74.78% <0.00%> (ø)
ledger/acctonline.go 79.41% <0.00%> (+0.52%) :arrow_up:
catchup/service.go 70.12% <0.00%> (+0.74%) :arrow_up:
data/transactions/verify/txn.go 44.64% <0.00%> (+0.89%) :arrow_up:
catchup/peerSelector.go 100.00% <0.00%> (+1.04%) :arrow_up:
... and 3 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Jul 27 '22 18:07 codecov[bot]

Catchpoint apply code appears broken feature

~/go/bin-cp-oom/catchpointdump net -l -n betanet.algodev.network -r 19780000 -s [ Done ] Downloaded http://r4.betanet.algodev.network:4160/v1/betanet-v1.0/ledger/brycg [ Done ] Loaded Unable to load catchpoint file into in-memory database : sql: no rows in result set

master

catchpointdump net -l -n betanet.algodev.network -r 19780000 -s [ Done ] Downloaded http://r3.betanet.algodev.network:4160/v1/betanet-v1.0/ledger/brycg [ Done ] Loaded

algorandskiy avatar Aug 19 '22 19:08 algorandskiy

vet: ledger/catchpointwriter_test.go:361:22: undeclared name: ioutil

Verified catchpoints creation and applying on betanet, all right.

algorandskiy avatar Aug 22 '22 15:08 algorandskiy