go-algorand-sdk icon indicating copy to clipboard operation
go-algorand-sdk copied to clipboard

Published 20 hours ago • verified publisher icon algorand

Make PRs obey `make`/`golint`

Open EvanJRichard opened this issue 4 years ago • 1 comments

Summary

At time of writing there is no check that a PR obeys golint. Indeed, the pre-PR screen does not even mention golint as a requirement. As such there are linting violations throughout go-sdk, especially in the v2 client. We need to change the pre-PR prompt to mention golint, and make Travis enforce golint, as it is in go-algorand.

EvanJRichard avatar Jun 24 '20 16:06 EvanJRichard

Moving to Icebox - PR is up as #186, but per conversation in standup, we might not want to apply this change.

EvanJRichard avatar Oct 15 '20 14:10 EvanJRichard