Aman Sharma

Results 234 comments of Aman Sharma

> If those are the operations, it does make sense. It makes sense to me now too. Instead of it making sense, I think I meant it was unnecessary because...

If we follow this approach to update spoon nodes, we shall only be updating the value corresponding to a specific role. We would be skipping the update of the source...

@martinezmatias I needed to confirm what is the expected behavior of the classifier in the examples you have proposed above. ```diff - int xxxxxx1 = foo001(0) ; + int xxxxxx1...

@monperrus @khaes-kth srcDiff's output for this diff. ![Screenshot from 2022-02-25 11-02-34](https://user-images.githubusercontent.com/35191225/155695769-9ed97692-56a9-49fd-acf8-fb3e62e469fc.png)

GumTree-JDT (`master` version as of the date this comment was created). ![Screenshot from 2022-02-25 11-18-34](https://user-images.githubusercontent.com/35191225/155698107-a745ec63-adf4-41ae-8652-fadaa90ac0b4.png) ![Screenshot from 2022-02-25 11-19-50](https://user-images.githubusercontent.com/35191225/155698171-36134345-d882-4c94-8cba-1e61191df9ab.png) It is not really clear which element moved unless you have...

### Mergely https://editor.mergely.com/Bmo5md7x/ ### GitHub diff view https://github.com/algomaster99/diffmin-examples/pull/7/files We can claim that all of them fail, if we say the _correct_ way to show the diff was 3 updates.

> Here, I'd say that scrDiff is better than gumtree-JDT for example. > And that the Github diff is the best. I agree with your opinions.

Came back at this and tried to produce a test for it. Turns out, it is working. The diff is being reported. I am not sure what fixed it, but...

I have not read what the CVEs dictate. I will post them here once I read it.

@slarse @martinezmatias @slarse , you said that we could instead AST diff between packages [here](https://github.com/SpoonLabs/gumtree-spoon-ast-diff/issues/154#issuecomment-816509973). Should we take one more step ahead and show the AST diff between modules? `CtModule`...