scout-extended icon indicating copy to clipboard operation
scout-extended copied to clipboard

Empty searchable array is indexed with only meta data.

Open wisoot opened this issue 6 years ago • 2 comments

Similar to the bug report in scout here: #350 - if meta data is not empty due to the setting to switch on soft_delete in scout.config.soft_delete.

In this line here: https://github.com/algolia/scout-extended/blob/v1.6.0/src/Jobs/UpdateJob.php#L109 checking on emptiness of searchable array should be perform separately from metadata as it will always be fault when soft_delete is enabled.

wisoot avatar Jun 27 '19 02:06 wisoot

@wisoot Do you think that you are able to do a pull request with tests on this?

nunomaduro avatar Jun 27 '19 08:06 nunomaduro

@nunomaduro Here is the PR: https://github.com/algolia/scout-extended/pull/193

wisoot avatar Jul 03 '19 01:07 wisoot