react-element-to-jsx-string icon indicating copy to clipboard operation
react-element-to-jsx-string copied to clipboard

Published 20 hours ago • verified publisher icon algolia

feat(formatting): render children as function

Open adammockor opened this issue 6 years ago • 5 comments

This is copy paste of https://github.com/algolia/react-element-to-jsx-string/pull/317 since it doesn't get merged due commitlint errors. I fixed that. Thanks @DavidBabel for implementing this. I can provide support to this PR if needed.

adammockor avatar Jan 04 '19 09:01 adammockor

I will fix the flow errors. But failing test is not related to this PR and local yarn run test works without error.

adammockor avatar Jan 04 '19 09:01 adammockor

Yep I don't get why it's failing on travis only image

vvo avatar Jan 04 '19 15:01 vvo

cc @Spy-Seth maybe?

vvo avatar Jan 04 '19 15:01 vvo

Do you use the same node version as your travis build ? node_js: node # lastest

DavidBabel avatar Jan 06 '19 00:01 DavidBabel

The ref/key order issue is fixed by #340. You should rebase your PR on top master 😃

armandabric avatar Jan 06 '19 08:01 armandabric