instantsearch icon indicating copy to clipboard operation
instantsearch copied to clipboard

Remove deprecated hogan.js dependency also from instantsearch.js

Open dewey opened this issue 4 months ago • 1 comments

🐛 Current behavior

Hey, there's currently a deprecated mkdirp dependency being pulled in by instantsearch.js. This was already partly removed in this PR but for some reason doesn't seem to be in the master branch.

Currently it can still be seen in https://github.com/algolia/instantsearch/blob/master/packages/instantsearch.js/package.json#L35, this is right now causing a deprecation warning as that project was deprecated 4 years ago.

npm warn deprecated [email protected]: Legacy versions of mkdirp are no longer supported. Please update to mkdirp 1.x. (Note that the API surface has changed to use Promises in 1.x.)

There was a PR to switch to a user-maintained version a few days ago that was rejected (For good reason).

Are there any plans to remove it from instantsearch.js?

🔍 Steps to reproduce

Build a project using instantsearch.js with npm and esbuild.

Live reproduction

https://codesandbox.com

💭 Expected behavior

No warning

Package version

[email protected]

Operating system

macOS

Browser

Firefox

Code of Conduct

  • [x] I agree to follow this project's Code of Conduct

dewey avatar Sep 05 '25 17:09 dewey

Yes, hogan will be removed in the next major version. If you don't use hogan templates (only functions, no strings), you can safely alias that dependency to a no-op.

Haroenv avatar Sep 08 '25 07:09 Haroenv