instantsearch icon indicating copy to clipboard operation
instantsearch copied to clipboard

fix(configure): ignore data attributes

Open Haroenv opened this issue 1 year ago • 2 comments

Summary

ignore data attributes in configure

Result

fixes https://github.com/getsentry/sentry-javascript/issues/12720#issuecomment-2396247718

I'm not yet convinced this is the right approach for all cases (may cause a slowdown possibly, although we already were spreading the props). Alternatively this could be in setQueryParameter or similar possibly, but would make that function more expensive.

In the mean time, anyone using the sentry plugin can use this patch

Haroenv avatar Oct 07 '24 10:10 Haroenv

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 393c969f36865aeaa7515bae65cd6a705889794e:

Sandbox Source
example-instantsearch-getting-started Configuration
example-react-instantsearch-getting-started Configuration
example-react-instantsearch-next-app-dir-example Configuration
example-react-instantsearch-next-routing-example Configuration
example-vue-instantsearch-getting-started Configuration

codesandbox-ci[bot] avatar Oct 07 '24 10:10 codesandbox-ci[bot]

Thank you @Haroenv ❤️

JonasBa avatar Oct 07 '24 13:10 JonasBa

Thank you, @Haroenv I’m currently dealing with this issue between Algolia and Sentry, and this would be helpful.

Do you know of any workaround in the meantime?

victordelva avatar Dec 18 '24 08:12 victordelva

@victordelva you can apply this patch in your code base using for example patch-package. For the moment it seems that sentry is more responsible for patching their code to avoid adding attributes everywhere.

Haroenv avatar Dec 18 '24 09:12 Haroenv

can be closed now that https://github.com/getsentry/sentry-javascript-bundler-plugins/pull/617 is merged

Haroenv avatar Feb 04 '25 14:02 Haroenv