instantsearch icon indicating copy to clipboard operation
instantsearch copied to clipboard

Installation problem: Property 'MarkerOptions' does not exist on type 'typeof maps''

Open Annoxis opened this issue 1 year ago • 2 comments

🐛 Current behavior

I get the following error at instantsearch.js/es/widgets/geo-search/geo-search.d.ts:213:63 : Property 'MarkerOptions' does not exist on type 'typeof maps'. Here is the faulty line of code: markerOptions: GeoSearchMarker<typeof google.maps.MarkerOptions | Partial<HTMLMarkerArguments>>;

Removing "typeof" fixes the issue as a workaround for development, but it won't be applicable in production.

🔍 Steps to reproduce

Simply download the relevant libraries, start a basic angular project and attempt to launch the front end. I am sorry, I have not been able to run the codesandbox online, but it worked locally.

Live reproduction

https://codesandbox.io/p/github/Annoxis/instantsearch_googlemaps_import_problem/main

💭 Expected behavior

My front end compile.

Package version

Instantsearch.js 4.72.2, types/google.maps 3.55.10, angular 15.2, npm 10.5.0

Operating system

Tested under Mac Sonoma and Windows 11 (WSL 2)

Browser

Irrelevant

Code of Conduct

  • [X] I agree to follow this project's Code of Conduct

Annoxis avatar Jun 27 '24 09:06 Annoxis

Your sandbox seems to be private, but I tried to reproduce and I don't see an error: https://codesandbox.io/p/sandbox/friendly-ben-jzt2xs?file=%2Fsearch.ts%3A100%2C1-111%2C6

Haroenv avatar Jun 27 '24 13:06 Haroenv

@Haroenv I updated the codesandbox, it should work now. The main difference between our codes is that I am using Angular and you are not.

Annoxis avatar Jun 28 '24 08:06 Annoxis

I can attest to this. It does not compile for me either.

KennethHoff avatar Aug 07 '24 14:08 KennethHoff

Same on my end

antoniobuyukluev avatar Aug 07 '24 15:08 antoniobuyukluev

I wonder if this is caused by somehow you having both @types/googlemaps and @types/google.maps installed. Can you check that? And if removing one of the two manually works

Haroenv avatar Aug 07 '24 15:08 Haroenv

I wonder if this is caused by somehow you having both @types/googlemaps and @types/google.maps installed. Can you check that? And if removing one of the two manually works

image i have only one type removing both from the photo is not fixing it

my local workaround is to comment it image but if remove the typeof image or remove the MarkerOptions image

it compiles

antoniobuyukluev avatar Aug 07 '24 16:08 antoniobuyukluev

@Haroenv image i think this is the reason

antoniobuyukluev avatar Aug 07 '24 16:08 antoniobuyukluev

Thanks, I believe the changes in https://github.com/algolia/instantsearch/pull/6319 will fix the issue then. Do you mind using the version that codesandbox will provide in the PR locally and see if that all works? thanks!

Haroenv avatar Aug 08 '24 10:08 Haroenv