instantsearch
instantsearch copied to clipboard
WIP: add missing modifierClick avoid preventDefault to links
Summary
You should be able to cmd-click on every link rendered by InstantSearch and open it in a new tab. The default behaviour should never be prevented if it's a modifier or special click.
Result
- Menu in React InstantSearch respects cmd-click
- Breadcrumb in InstantSearch.js respects cmd-click
TODO:
- tests (possibly something global that cmd-clicks on every link and shows the DOM didn't change?)
- ensure there's no other cases of this pattern
This pull request is automatically built and testable in CodeSandbox.
To see build info of the built libraries, click here or the icon next to each commit SHA.
Latest deployment of this branch, based on commit 0eed7039d918cb33d2861dfc64cc3286a84d3ac8:
Sandbox | Source |
---|---|
InstantSearch.js | Configuration |
react-instantsearch-app | Configuration |
example-react-instantsearch-default-theme | Configuration |
example-react-instantsearch-next-app-dir-example | Configuration |
example-vue-instantsearch-default-theme | Configuration |