instantsearch-ios icon indicating copy to clipboard operation
instantsearch-ios copied to clipboard

Sequence extension with `sorted(by:)` function should be internal

Open qizh opened this issue 1 year ago • 1 comments

https://github.com/algolia/instantsearch-ios/blob/09c9fa3c762064b005fb4bb56b9f28b426b77b62/Sources/InstantSearchCore/Extensions/Sequence%2BConvenience.swift#L10-L11

So it won't pollute code suggestions for projects using this library. Also many libraries or projects have similar function implemented, usually with the same definition.

In some cases it can even produce a warning in Xcode 14. When function with the same name is used in inlinable code when InstantSearchCore is added to the project but is not imported in this specific file.

Warning screenshot

qizh avatar Apr 13 '23 04:04 qizh

Still the case in Xcode 15

qizh avatar Nov 16 '23 06:11 qizh