docsearch icon indicating copy to clipboard operation
docsearch copied to clipboard

fix: make react an optional peer dependency in `@docsearch/react`

Open brc-dd opened this issue 2 years ago • 4 comments

fixes (partially) #1272

brc-dd avatar Jan 16 '22 09:01 brc-dd

Deploy Preview for docsearch canceled.

Name Link
Latest commit 06363c7210a3495463e7ced7eb43e2995056dcff
Latest deploy log https://app.netlify.com/sites/docsearch/deploys/62fac1d57bbb550008bd0a33

netlify[bot] avatar Jan 16 '22 09:01 netlify[bot]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e1ad16dcac1cf4ff126e928d6dea22f7853f15c4:

Sandbox Source
Vanilla Configuration

codesandbox-ci[bot] avatar Jan 16 '22 09:01 codesandbox-ci[bot]

Hi @shortcuts! Sorry for pinging you directly. But can this be looked into?

brc-dd avatar Jun 03 '22 18:06 brc-dd

@brc-dd it looks like this PR needs to be rebased

@shortcuts would you be able to review this PR? It's a major stumbling block to using Algolia with non-React projects like Vue, Svelte, etc. Are there any concerns you have or things we could help test?

benmccann avatar Aug 09 '22 16:08 benmccann

Thanks for the merge! Any chance we can get a new release?

benmccann avatar Aug 16 '22 04:08 benmccann

Thanks for the merge! Any chance we can get a new release?

Hey, it's released in 3.2.1!

shortcuts avatar Aug 16 '22 10:08 shortcuts

@shortcuts are you sure? 😅

https://www.npmjs.com/package/@docsearch/react image

SimenB avatar Aug 16 '22 11:08 SimenB

@shortcuts are you sure? 😅

https://www.npmjs.com/package/@docsearch/react

image

Oops, now it's good!

shortcuts avatar Aug 16 '22 11:08 shortcuts