create-instantsearch-app icon indicating copy to clipboard operation
create-instantsearch-app copied to clipboard

Ask for folder name if not provided in the arguments

Open bobylito opened this issue 6 years ago • 3 comments

Bug description

When the folder name is not provided, the CLI fails. This is an OK behavior when installed globally. However this is a problem with yarn create as yarn will check if there is a new version, which takes some time.

How to reproduce

  • yarn create instantsearch-app
  • yarn downloads stuff
  • fail because there is no folder provided
  • type again yarn create instantsearch-app folder
  • download again
  • now it's good

Expected behavior

A better user experience would be to ask for the missing parameter.

bobylito avatar Jul 25 '18 12:07 bobylito

Interesting! That'd be a nice command-line option to add if missing in the arguments.

The "folder name" is rather the app name (that can contain a folder).

francoischalifour avatar Jul 25 '18 12:07 francoischalifour

The "folder name" is rather the app name (that can contain a folder).

Even I got confused here. Right now we have the app name and the folder mixed together as one argument "folder name".

My problem is when you don't pass the mandatory parameter from the command line, you have to restart the whole script which is a UX that can be improved by asking the missing parameter instead of failing.

bobylito avatar Jul 27 '18 09:07 bobylito

"Path name" is the appropriate term.

Yes, I totally understand the feature and its value. I will work on it!

francoischalifour avatar Jul 27 '18 09:07 francoischalifour