angular-instantsearch icon indicating copy to clipboard operation
angular-instantsearch copied to clipboard

Compilation error: Cannot find module 'places.js' or its corresponding type declarations.

Open kisamoto opened this issue 2 years ago • 6 comments

Describe the bug 🐛

Receiving a compilation error when trying to use the latest version of angular-instantsearch.

Expected behavior 💭

Successful compilation.

Environment:

  • OS: Linux
  • Browser: All
  • Version:
    • "angular-instantsearch": "^4.4.0",
    • "@angular/core": "^15.2.0",

Additional context

kisamoto avatar Mar 10 '23 18:03 kisamoto

@kisamoto I was able to fix this compilation error by installing npm i -D @types/places & npm i places.js .

fourthofaugust avatar Mar 12 '23 01:03 fourthofaugust

Can confirm that fixes it but should either:

  1. be in the docs;
  2. or have the dependency removed (places.js is in the public archive)

kisamoto avatar Mar 13 '23 14:03 kisamoto

@kisamoto Yeah that's true. Maybe one of the maintainers should document it.

fourthofaugust avatar Mar 13 '23 16:03 fourthofaugust

@fourthofaugust @kisamoto it’s wasn’t resolved when using yarn add @types/places

mazenaboelanin avatar Mar 15 '23 14:03 mazenaboelanin

Can someone make a reproduction of this? When I'm trying this in the examples, places doesn't need to be loaded.

Haroenv avatar Mar 15 '23 14:03 Haroenv

@Haroenv solved by running yarn add @types/places && yarn add places.js

mazenaboelanin avatar Mar 15 '23 14:03 mazenaboelanin