algoliasearch-magento icon indicating copy to clipboard operation
algoliasearch-magento copied to clipboard

Broken with Bootstrap5

Open MarksEliel opened this issue 3 years ago • 4 comments

When do you intend to release an update compatible with bootstrap 5?

MarksEliel avatar May 06 '21 22:05 MarksEliel

I made this work with bootstrap 5 @MarksEliel @davicotico. The only problem I saw was the icon picker not displaying its pop up in the right place. To fix this, change this line:

var tip = ($.fn.bsVersion() === '3.x') ? el.tip() : $(el.getTipElement())

(https://github.com/davicotico/jQuery-Menu-Editor/blob/master/bootstrap-iconpicker/js/bootstrap-iconpicker.js#L497)

to:

                              var tip = ($.fn.bsVersion() === '3.x') ? el.tip() 
                                      : ($.fn.bsVersion() === '5.x') 
                                      ? $(bootstrap.Popover.getInstance($this).getTipElement())
                                      : $(el.getTipElement())

This was helpful: https://github.com/itsjavi/bootstrap-colorpicker/issues/327#issuecomment-843082927

Is anyone able to recreate the minified js file? It's not very important to me, so I will just serve the modified un-minified file for now

glutamate avatar Feb 21 '22 11:02 glutamate

you should also change the float-right class in TButtonGroup to float-end

glutamate avatar Feb 27 '22 21:02 glutamate

None of this is working in Bootstrap 5.3.2

Hope this gets fixed soon.

InsiteFX avatar Oct 21 '23 08:10 InsiteFX

Hi @InsiteFX , @glutamate , @MarksEliel
You can try Vanilla Javascript Menu Editor. I have worked on and will continue to work on Vanilla Javascript Menu Editor. jQuery Menu Editor is not deprecated, but for now, I have no plans to update it

davicotico avatar Oct 22 '23 02:10 davicotico