algoliasearch-client-python icon indicating copy to clipboard operation
algoliasearch-client-python copied to clipboard

runtime error trying to deserialise non json responses

Open nunomaduro opened this issue 4 years ago • 0 comments

The Python API client throws a runtime exception while attempting to desialize a non json response. Note that, as described on the JavaScript API Client, we should NOT deserialise responses on those cases:

isTimedOut || isNetworkError(response) || (~~(status / 100) !== 2 && ~~(status / 100) !== 4)

Source: https://github.com/algolia/algoliasearch-client-javascript/blob/master/packages/transporter/src/concerns/retryDecision.ts#L12.

Solution: Create a pull request that ensures that no response.json() is performed on the cases mentioned above.

nunomaduro avatar Apr 09 '20 13:04 nunomaduro