algoliasearch-client-python icon indicating copy to clipboard operation
algoliasearch-client-python copied to clipboard

retryable error doesn't increment connection timeout number

Open nunomaduro opened this issue 5 years ago • 0 comments

Looking at the retry specs, we see that:

When retrying, use the next host in your array.
When retrying because of a timeout, raise the timeouts like this:
number_of_tries * base_timeout
Example: Search (5s timeout) → Search timeout → Search (10s timeout) → Repeat.

At the moment, on the Python API Client we don't use yet the retry_count for this.

Goal:

  1. Multiple timeouts by the number of tries on the line https://github.com/algolia/algoliasearch-client-python/blob/97a6f15542f6a8951cdbcd0d2881a744ec24e329/algoliasearch/http/transporter.py#L72.

  2. Add a test on it.

Implementation on C#: https://github.com/algolia/algoliasearch-client-csharp/blob/42ab1842f859df87482602b12d5cb714bfa8ec71/src/Algolia.Search/Transport/HttpTransport.cs#L118

nunomaduro avatar Jul 23 '19 14:07 nunomaduro