algoliasearch-client-php icon indicating copy to clipboard operation
algoliasearch-client-php copied to clipboard

Published 20 hours ago • verified publisher icon algolia

Addition of gzip feature

Open chloelbn opened this issue 5 years ago • 3 comments

Q A
Bug fix? yes/no
New feature? yes/no
BC breaks? no
Related Issue Fix #563
Need Doc update yes/no

Describe your change

What problem is this fixing?

chloelbn avatar Jul 08 '19 16:07 chloelbn

@chloelbn Let me know when I can review this 👍

nunomaduro avatar Jul 10 '19 17:07 nunomaduro

@chloelbn I will check why travis is not passing the tests.

nunomaduro avatar Jul 11 '19 16:07 nunomaduro

  • [ ] Unit level tests for each compressor testing if headers + body is encoded properly.
  • [ ] Unit level tests for making sure only POST || PUT are encoded by compressors.
  • [ ] Integration level tests for making sure compressors work as entire solution.
  • [ ] Memory optimisation/refactor while duplication body variables on the line https://github.com/algolia/algoliasearch-client-php/pull/568/files#diff-998e5f334860944888f3ed7efcecdd5aR126

nunomaduro avatar Jul 17 '19 15:07 nunomaduro