algoliasearch-client-csharp icon indicating copy to clipboard operation
algoliasearch-client-csharp copied to clipboard

Add SourceLink and push symbols to NuGet.org

Open RomainHautefeuille opened this issue 2 years ago • 1 comments

Q A
Bug fix? no
New feature? yes
BC breaks? no
Related Issue
Need Doc update no

Describe your change

The purpose of this change is to push debug symbols as a separate .snupkg to NuGet.org. This package can be retrieved by IDE (Visual Studio, VS Code) during debug, enabling stepping into source code with the help of SourceLink. Using latest snupkg format. ContinuousIntegrationBuild should be set during CI to avoid linking to paths from build vm, but not when built manually where local paths are relevant. (I couldn't easily test this part as I don't have access to a CircleCI platform, I am assuming that env variable CIRCLECI is set during CI) Command dotnet nuget push *.nupkg should also push .snupkg if found.

What problem is this fixing?

No debug info available for stack frame from algoliasearch-client-csharp when debugging.

RomainHautefeuille avatar Mar 10 '22 11:03 RomainHautefeuille

Looks fine; the snpkg will only be available to people pulling via the v3 nuget api; you could get away with removing the version/setting it broader.

ChrisMcKee avatar May 15 '22 08:05 ChrisMcKee