acme-lib icon indicating copy to clipboard operation
acme-lib copied to clipboard

Bug Fix: Multiple Domain Names for Single Certificate

Open Jaffa-Cakes opened this issue 1 year ago • 0 comments

Fix

Hello, I discovered an issue with acme-lib when a certificate that covers multiple domains is created.

When requesting a new cert, the domains the certificate covers are sent to the desired certificate authority all together in a single logical "alternate domain" field. This causes an error as there are multiple domains in a field expecting one, the solution was to call the .dns method multiple times and loop through the domains instead of concatenating them into a single string so that each domain gets its own logical "alternate domain" field.

I ran into this issue when attempting to create certificates with both the live version of Let's Encrypt and their staging version.

Jaffa-Cakes avatar May 15 '23 04:05 Jaffa-Cakes