Gergely Nagy

Results 406 comments of Gergely Nagy

Alternatively: https://apt.llvm.org/. We could just use the packages from there, and then we'd have clang-format-15 available in the VM, no docker necessary.

> We're running it in the `ubuntu-latest` image, which claims to have `clang-format-14` available, but if I set it up to use that, it errors because the file doesn't exit....

To test if this works correctly, I implemented a `backup` and a `restore` command for one of the tools in `kaleidoscope-focus.rs`: keyboardio/kaleidoscope-focus.rs#1. It seems to be working quite well, and...

While this does add a bit of code size (~146 bytes on the default Model01 firmware, our tightest one), considering how much it buys us, I'm quite happy with that....

We should go all the way then, and go with their suggestion of using a command table (#1285), otherwise we'll either end up duplicating a lot of strings, or pushing...

I'm 100% for standardizing, but wanted to give a little context about *why* the order was wildly different between the various keyboards: mostly due to us not wanting to change...

#1293 will cause conflicts here, I'll resolve those, and apply the same standardization to the rest of the sketches that we ship with Chrysalis. No need to rebase it on...

Would the command table declaring the entire format require us to allocate memory for the parsed input of all commands, together? Because that basically means we need to have enough...

> I'm not entirely convinced that eeprom.contents as a write command is actually generally useful. It... had its uses. I used to use it a lot when testing firmware changes:...

> It would mean that we would need to at least dynamically allocate enough RAM to hold the parsed arguments of the command with the longest arguments. Can't we statically...