Alfonso Garcia-Caro

Results 315 comments of Alfonso Garcia-Caro

Sorry this is not very clear at the moment @jannikbuschke, but Typescript compilation is not in a working state yet. It was added experimentally a while ago but we haven't...

It's actually the same as the JS compilation, the only difference is there are several switches in the Fable2Babel step so when Typescript is selected type annotations are included in...

Yes, the Promise `then` bindings are there for completeness but it's difficult to represent a function that returns different types in F#, so the recommended way is to use the...

Sorry to hear you're having trouble with the documentations @napretep. Docs can always be improved though I'm usually skeptical about putting too much info in the fable.io site because the...

Sorry, scratch the part about the dependencies, I had a wrong understanding about how the Elmish program was being terminated 😅 I added the dependencies back and also add a...

Sorry @Zaid-Ajaj, I did a force push and this seems to confuse Github notifications. This is ready to merge when you have a moment to look at (but please check...

Actually, I just realized if I decorate the type with `CompiledName("useReact")` I can get the same effect as when using the `Hook` attribute. Anyways, in my tests there didn't seem...

@Zaid-Ajaj `npm test` is failing, but this is still running with Fable 2. `npm run test:nagareyama` works for me locally. Do we still want to maintain the tests for Fable...

Thanks @Zaid-Ajaj! I made a change in [this commit](https://github.com/Zaid-Ajaj/Feliz/pull/515/commits/1463415715c632b6ae31bed637900b5f88514c7d) that fixes the Fable 2 tests, but it exposes a `useElmish` function besides the `React` overloads. I don't have a strong...

Using `use-sync-external-store` makes sense, we had a similar discussion here: https://github.com/alfonsogarciacaro/fable-react-sample/issues/1#issuecomment-1286542980 In any case, please note that: - this avoids having to update to React 18 (which is important) -...