kakurenbo-puti icon indicating copy to clipboard operation
kakurenbo-puti copied to clipboard

Method soft_destroyed? should read attribute soft_delete_column?

Open akirakoyasu opened this issue 7 years ago • 1 comments

Hi, thank you for a cho-iketeru gem.

soft_destroyed? executes SQL, now. But for performance, I think it's better to read attribute soft_delete_column.

I wonder why don't you do?

akirakoyasu avatar Oct 20 '17 00:10 akirakoyasu

@akirakoyasu

HI, thanks for a report.

This gem supports dependent delete. https://github.com/alfa-jpn/kakurenbo-puti#definition-of-the-dependency

So, A resource can't known a self destroyed status without a SQL. But, I think it can optimize when a model doesn't use dependent delete.

best regards,

alfa-jpn avatar Oct 24 '17 14:10 alfa-jpn