custom-qr-generator icon indicating copy to clipboard operation
custom-qr-generator copied to clipboard

Highlight anchor elements for better recognition seems break in Library version 2.0.0-alpha01

Open hardikbhalodi opened this issue 2 years ago • 8 comments

Library version 'com.github.alexzhirkevich:custom-qr-generator:2.0.0-alpha01'

Code Snippet QrVectorOptions.Builder options =new QrVectorOptions.Builder()... options.setAnchorsHighlighting(new QrHighlighting(HighlightingType.Default.INSTANCE, HighlightingType.Default.INSTANCE, HighlightingType.None.INSTANCE, 0.6f));

Library version 2.0.0 -alpha01 ouput (Alpha not applying)
Screenshot_153452

Library version 1.6.2 ouput (Correct) Screenshot_154359

Quoted issue https://github.com/alexzhirkevich/custom-qr-generator/issues/27#issue-1690411367

hardikbhalodi avatar Aug 09 '23 10:08 hardikbhalodi

you have to add alpha manually to the color. alpha paramter will be removed. color parameter will be added to Default highlighting. For now you can use styled one with default arguments and set color to transparent white

alexzhirkevich avatar Aug 09 '23 10:08 alexzhirkevich

I tried that way here is code snippet

 HighlightingType type=new HighlightingType.Styled(null,getQRVectorColor(Color.parseColor("#66ffffff")));
 options.setAnchorsHighlighting(new QrHighlighting(type,
                    type, HighlightingType.None.INSTANCE, 0.6f));

here is Output, getting some margin in version eye Screenshot_165803

hardikbhalodi avatar Aug 09 '23 11:08 hardikbhalodi

Use elementShape from here https://github.com/alexzhirkevich/custom-qr-generator/issues/38#issuecomment-1633356526 and create frame for it with the size of 5, not 7

alexzhirkevich avatar Aug 09 '23 11:08 alexzhirkevich

Or just use stable version

alexzhirkevich avatar Aug 09 '23 11:08 alexzhirkevich

Version stable 'com.github.alexzhirkevich:custom-qr-generator:1.6.2'

With code snippet alpha inside color

HighlightingType type=new HighlightingType.Styled(null,getQRVectorColor(Color.parseColor("#66ffffff")));
options.setAnchorsHighlighting(new QrHighlighting(type,
                   type, HighlightingType.None.INSTANCE, 0.6f));

Screenshot_165803

with old code snippet alpha as separate parameter options.setAnchorsHighlighting(new QrHighlighting(HighlightingType.Default.INSTANCE, HighlightingType.Default.INSTANCE, HighlightingType.None.INSTANCE, 0.6f));

Screenshot_170515

hardikbhalodi avatar Aug 09 '23 11:08 hardikbhalodi

I mean use it how you have used it before, without new code snippet. I'll fix alpha version soon

alexzhirkevich avatar Aug 09 '23 11:08 alexzhirkevich

@alexzhirkevich new alpha is fixed?

hardikbhalodi avatar Oct 09 '23 05:10 hardikbhalodi

Hello. Can I ask how to create a QR code like this? Can you guide me? @hardikbhalodi @alexzhirkevich

AKFEvn avatar Mar 17 '24 12:03 AKFEvn