wikitools icon indicating copy to clipboard operation
wikitools copied to clipboard

Fixed wrong version in setup.py for release tag 1.3

Open vjancik opened this issue 9 years ago • 2 comments

vjancik avatar Jul 21 '15 19:07 vjancik

This pull request is confusing me.

It looks like this pull request was created on July 21, 2015 and has two associated commits.

One of the pull request's commits, a18b321eaff8fd8337843e32f398006ca77f582b, is dated July 21, 2015.

The other, 8e203e7d9a778ada47b1258df62ddb14cdafaa0b, is dated June 6, 2015. This commit has a subject line of "Fixed wrong version in setup.py for release tag 1.3" and is changing the version number from 1.3 to 1.4. I'm not sure whether this was intentional.

Meanwhile, 72a00c96e97c6d1017f607b9ebc8e1a520bd0d3e from June 6, 2015 already landed in master. This commit similarly has a subject line of "1.3 released" but is actually changing the version strings to 1.4.

I'm lost. What should happen with this pull request? Should it be merged or closed at this point?

Maybe wikitools 1.3 will end up being like PHP 6 or Windows 9? :-)

mzmcbride avatar Jun 04 '16 23:06 mzmcbride

Close. The issue was that the commit marked as release 1.3 had version 1.2. Only fix for this would be to modify the history (e.g. rebase these commits into the history) and make a new release commit pointer, that points to the fixed commit with version 1.3. And the reason we needed this (we fixed it locally with a patch) was that we were pointing to your release 1.3 in a Fedora Package (git source), but there was an installation (or something else, don't remember) issue, which required the correct version.

vjancik avatar Jun 05 '16 12:06 vjancik