ircd.js icon indicating copy to clipboard operation
ircd.js copied to clipboard

Fix: Don't crash on kick without user

Open TheBenji opened this issue 10 years ago • 4 comments

If you do "/KICK " and don't specify a user the server crashes

home/ben/workspace/ircd.js/lib/commands.js:123 userNames = users.split(','), ^ TypeError: Cannot call method 'split' of undefined at Object.Commands.KICK (/home/ben/workspace/ircd.js/lib/commands.js:123:27) at Object.Server.respondToMessage (/home/ben/workspace/ircd.js/lib/server.js:171:36) at Object.Server.respond (/home/ben/workspace/ircd.js/lib/server.js:181:14) at Object.Server.data (/home/ben/workspace/ircd.js/lib/server.js:320:10) at Carrier. (/home/ben/workspace/ircd.js/lib/server.js:277:51) at Carrier.emit (events.js:95:17) at /home/ben/workspace/ircd.js/node_modules/carrier/lib/carrier.js:71:15 at process._tickCallback (node.js:419:13)

Doesn't happen anymore with this fix and just sends an "needs more arguments"

TheBenji avatar Oct 28 '14 13:10 TheBenji

Good catch, thanks for the fix. Your patch seems to alter the indentation of several lines. Could you please clean that up?

sespindola avatar Nov 04 '14 14:11 sespindola

Just seems like it. The whole part between l137-160 is now within the "else"-block and therefore the indentation moved a little.

I (well, my editor :P) also removed the trailing whitespaces (l336 & l498).

Hope that makes sense

TheBenji avatar Nov 04 '14 14:11 TheBenji

Can you merge this please???? @sespindola

orliesaurus avatar May 12 '15 16:05 orliesaurus

lol is there a way i can participate in this? otherwise i'll gladly fork this as i've been looking for a node.js implementation of irc

Meleeman01 avatar Aug 02 '21 05:08 Meleeman01