ircd.js
ircd.js copied to clipboard
alexyoung
Project activity?
Is this project still alive? The issues seem have been untouched for over a year. I'm considering using this in an upcoming project and I'm wondering if the code will continue to be advanced.
I wanted to work on it, but I'm too busy working on my book, blog posts, job, baby, etc.
Totally understandable. Have you considered adding other contributors to the repo?
Alex, if you're looking for contributors, I volunteer. I have some free time and I could help mantain this project.
Regards, Sebastian.
@alexyoung @sespindola I can also help out from time to time, and also for the case there's an extra eye needed before accepting pull requests.
Guys there are some pull requests in the queue. I suggest we take a look at them and decide what to merge or not.
Here is my feedback on the current pull requests:
The "Adding callback when the server is booted" request should not be merged in as-is but can be easily implemented in the current stream. It lacks proper implementation by using type checking and a different method of calling the passed function.
The "Fix bcrypt warnings" request should also be implemented slightly differently but provides the appropriate direction given the use of proper type checking.
I would like to personally work on the "Add Websocket Support" request as it is related to one of the original issues I was observing with this project. I'm in favor of using a less bloated solution for the web socket support such as the WS library or Socket.io's replacement (engine.io). Generally speaking though, the way this change was implemented looks good to me but simply should use a different library. Engine.io would be a drop in replacement for Socket.io and WS could be very easily implemented in place of it as well. WS is at the core of these other libraries so the decision really relies upon whether or not the additional features are or will be needed.
I haven't personally reviewed the changes made in the "Don't remove channel unless all users have parted" request yet so I can't speak on this. I also have not reviewed the "dded support for multiple listening ports and made winston accessible" request but will try to make time to do so in the next few days if not tonight sometime.
Update: I just found the following issue that wasn't queued as a pull request but does include some fixes to be reviewed. I will review this at the same time I review the aforementioned other two that I haven't checked out yet. "Multiple OPERS cause login, then password incorrect" - https://github.com/alexyoung/ircd.js/issues/42
Thoughts related to my responses?
Alex,
I suppose I was not one of the two you added as a collaborator so I can not provide any further assistance on this matter.
I can add you, but I don't think websocket support should be added. My idea was to make ircd.js a simple core daemon, and then have ircd-web which would have WebSockets, a UI, and so on. What do you think?
I'll add you as an admin now.
@SpiderMatt3825U @alexyoung I also agree that the websocket support shouldn't be added to ircd.js, we should focus instead on bugfixes and the planned features listed in the README file (and review the pull requests too).
@alexyoung @alessioalex I completely agree with both of you. Until you said something, I wasn't actually aware of plans to create a second project focused on the web based side of it. I will maintain focus as you both desire so no worries.
Hello, I've just created #69 to write a message to the console through winston on startup. It's just a single line so, unless there's any objections, I'll merge it in a couple days.
Here's my two cents regarding the pending pull requests: "Adding callback": I agree it shouldn't be merged. It doesn't offer any functionality as it is right now.
"Fix bcrypt warnings": I've tested the pull request and works fine. It should be merged, since
the hash function, as is written, generates a random salt with 10 processing rounds.
@SpiderMatt3825U, by type checking you mean doing a typeof on the text variable to ensure
it is a string? If so, I'm ok with it, even if it wasn't part of the original code.
"Add websocket support": I agree with Alex, this project should concentrate on being a great irc server and any client functionality should be developed separately. For those interested in a websocket client, I recommend checking out thedjpetersen/subway which is a web based irc client developed with express. +1 for closing.
"Multiple OPERs cause login, the password incorrect": i'm testing it right now and will convert it to a pull request. Will reference the issue and add the user to to contributors if it gets merged.
I'll test the rest of the pull requests and will update this issue.
Cheers, Sebastian.
We've started using this at Gitter and has just got into test phase in production. Would be happy to chat about helping with contributing too.
Feel free to check it out and give it a test drive for us: https://irc.gitter.im (you'll need to use Gitter first).
FYI we've deployed it in a multiple server configuration behind an AWS ELB load balancer and so far it seems to be performing nicely, albeit with minimum traffic.
Great work btw!
@mydigitalself, I just connected to your irc server and except for a couple retries, which may have been caused by the ELB, it worked just fine. Great product!
Regarding contributions, any pull requests, issue reports or feature requests are more than welcome.
Cheers! Sebastian.
Hey Sebastian,
Odd, you shouldn't have had retries, will keep an eye on it, thanks for letting me know. Feel free to drop into #gitterHQ/gitte, we all hang out there and I'm available as mydigitalself (obviously).
Cheers Mike