haskell-code-explorer icon indicating copy to clipboard operation
haskell-code-explorer copied to clipboard

Port to GHC 9.x.x and emacs package

Open ycpei opened this issue 3 years ago • 3 comments

Hello,

I ported haskell-code-explorer to GHC 9.x.x, more specifically 9.2.2 but probably at most only minor changes are needed for other versions with major version 9. Recently I have been happily using an Emacs package to talk to the server exclusively, so I removed the js client. You may find the last commit with a web client at https://g.ypei.me/hcel.git/tree/?h=last-web-client. Though my fork is currently just an indexer / server now, I might add back a simpler web client that does not require handling npm vulnerabilities once I have improved the server more (e.g. removing dependency on cabal-helper if possible).

I am happy to send pull requests here, if folks are ok with the license (AGPLv3+) covering my code.

Best, Yuchen

ycpei avatar Sep 19 '22 01:09 ycpei

Hello,

Thank you for working on this!

Pull requests are welcome. I'm perfectly ok with the AGPLv3+ license.

alexwl avatar Sep 19 '22 12:09 alexwl

On Mon 2022-09-19 05:55:05 -0700, Alexey Kiryushin wrote:

Hello,

Thank you for working on this!

Pull requests are welcome. I'm perfectly ok with the AGPLv3+ license.

Great! I will prepare them in the next few days. A quick question: do you want the code in the pull requests to retain the CPP templates used for GHC version compatibility? In my port I removed them all for simplicity.

Best, Yuchen

-- PGP Key: 47F9 D050 1E11 8879 9040 4941 2126 7E93 EF86 DFD0 https://ypei.org/assets/ypei-pubkey.txt

ycpei avatar Sep 20 '22 12:09 ycpei

I believe it's better to retain the CPP templates.

alexwl avatar Sep 21 '22 07:09 alexwl